[PATCH] Fix degfault when using pyrpc ClientConnection over TCP

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[PATCH] Fix degfault when using pyrpc ClientConnection over TCP

Samba - samba-technical mailing list
The endpoints string array in the ndr_interface_table was not
initialized, causing a segfault when making a connection over TCP.

The added tests will trigger the segfault if run on an unpatched pyrpc.c

Review and push appreciated

Gary

0001-pyrpc-ClientConnection-fix-segfault.patch (3K) Download Attachment
signature.asc (484 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] Fix degfault when using pyrpc ClientConnection over TCP

Samba - samba-technical mailing list
On Fri, 2017-04-21 at 06:53 +1200, Gary Lockyer via samba-technical
wrote:
> The endpoints string array in the ndr_interface_table was not
> initialized, causing a segfault when making a connection over TCP.
>
> The added tests will trigger the segfault if run on an unpatched
> pyrpc.c
>
> Review and push appreciated

Other than a missing P in TCP:

Reviewed-by: Andrew Bartlett <[hidden email]>

Thanks,

Andrew Bartlett

--
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba


Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] Fix degfault when using pyrpc ClientConnection over TCP

Samba - samba-technical mailing list
On Thursday, 20 April 2017 21:30:34 CEST Andrew Bartlett via samba-technical
wrote:

> On Fri, 2017-04-21 at 06:53 +1200, Gary Lockyer via samba-technical
>
> wrote:
> > The endpoints string array in the ndr_interface_table was not
> > initialized, causing a segfault when making a connection over TCP.
> >
> > The added tests will trigger the segfault if run on an unpatched
> > pyrpc.c
> >
> > Review and push appreciated
>
> Other than a missing P in TCP:
>
> Reviewed-by: Andrew Bartlett <[hidden email]>
>
> Thanks,
>
> Andrew Bartlett


And missing brackets!!!!


RB+ and pushed to autobuild.

--
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             [hidden email]
www.samba.org

Loading...