[PATCH] Fix coverity issue in ctdb

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] Fix coverity issue in ctdb

Samba - samba-technical mailing list
Hi,

Please review and push.

Amitay.

0001-ctdb-tools-Fix-CID-1414746.patch (2K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Fix coverity issue in ctdb

Samba - samba-technical mailing list
On Wed, Sep 06, 2017 at 11:34:32AM +1000, Amitay Isaacs via samba-technical wrote:
> Hi,
>
> Please review and push.

Are you sure that fixes 1414746? I don't fully understand the CID, but
my impression is that the the overflow is not from assigning ssize_t
to int.

Volker

--
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:[hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Fix coverity issue in ctdb

Samba - samba-technical mailing list
Hi Volker,

On Wed, Sep 6, 2017 at 4:03 PM, Volker Lendecke <[hidden email]>
wrote:

> On Wed, Sep 06, 2017 at 11:34:32AM +1000, Amitay Isaacs via
> samba-technical wrote:
> > Hi,
> >
> > Please review and push.
>
> Are you sure that fixes 1414746? I don't fully understand the CID, but
> my impression is that the the overflow is not from assigning ssize_t
> to int.
>
>
You are correct. It's not the fix for actual CID.  Actual CID is the
overflow of db_flags.

Here are the modified patches.

- first patch is fixing the overflow (int --> ssize_t)
- second patch should fix the CID

Amitay.

ctdb.patch (3K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Fix coverity issue in ctdb

Samba - samba-technical mailing list
On Thu, 7 Sep 2017 11:43:49 +1000, Amitay Isaacs via samba-technical
<[hidden email]> wrote:

> On Wed, Sep 6, 2017 at 4:03 PM, Volker Lendecke <[hidden email]>
> wrote:
>
> > On Wed, Sep 06, 2017 at 11:34:32AM +1000, Amitay Isaacs via
> > samba-technical wrote:  
> > > Hi,
> > >
> > > Please review and push.  
> >
> > Are you sure that fixes 1414746? I don't fully understand the CID, but
> > my impression is that the the overflow is not from assigning ssize_t
> > to int.
> >
> >  
> You are correct. It's not the fix for actual CID.  Actual CID is the
> overflow of db_flags.
>
> Here are the modified patches.
>
> - first patch is fixing the overflow (int --> ssize_t)
> - second patch should fix the CID

Reviewed-by: Martin Schwenke <[hidden email]>

peace & happiness,
martin

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Fix coverity issue in ctdb

Samba - samba-technical mailing list
On Fri, 8 Sep 2017 16:51:44 +1000, Martin Schwenke via samba-technical
<[hidden email]> wrote:

> On Thu, 7 Sep 2017 11:43:49 +1000, Amitay Isaacs via samba-technical
> <[hidden email]> wrote:
>
> > On Wed, Sep 6, 2017 at 4:03 PM, Volker Lendecke <[hidden email]>
> > wrote:
> >  
> > > On Wed, Sep 06, 2017 at 11:34:32AM +1000, Amitay Isaacs via
> > > samba-technical wrote:    
>  [...]  
> > >
> > > Are you sure that fixes 1414746? I don't fully understand the CID, but
> > > my impression is that the the overflow is not from assigning ssize_t
> > > to int.
> > >
> > >    
> > You are correct. It's not the fix for actual CID.  Actual CID is the
> > overflow of db_flags.
> >
> > Here are the modified patches.
> >
> > - first patch is fixing the overflow (int --> ssize_t)
> > - second patch should fix the CID  
>
> Reviewed-by: Martin Schwenke <[hidden email]>

... and pushed.

peace & happiness,
martin