[PATCH] Fix bug #13193 - incorrect use of kernel oplock logic.

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] Fix bug #13193 - incorrect use of kernel oplock logic.

Samba - samba-technical mailing list
Patch is fairly self-explainatory. Reporter
confirmed the fix. Causes all kernel oplock
handling functions to use identical logic to
detect kernel oplocks being on or off.

Please review and push if happy !

Jeremy

0001-s3-smbd-Use-identical-logic-to-test-for-kernel-oploc.patch (2K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Fix bug #13193 - incorrect use of kernel oplock logic.

Samba - samba-technical mailing list
On Wed, Jan 03, 2018 at 09:56:27AM -0800, Jeremy Allison via samba-technical wrote:
> Patch is fairly self-explainatory. Reporter
> confirmed the fix. Causes all kernel oplock
> handling functions to use identical logic to
> detect kernel oplocks being on or off.
>
> Please review and push if happy !

Just a minor nit-pick: I find "koplocks!=NULL" easier to read than
just "koplocks". But that might be just me, sorry.

Volker

--
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:[hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Fix bug #13193 - incorrect use of kernel oplock logic.

Samba - samba-technical mailing list
On Wed, Jan 03, 2018 at 07:41:07PM +0100, Volker Lendecke wrote:

> On Wed, Jan 03, 2018 at 09:56:27AM -0800, Jeremy Allison via samba-technical wrote:
> > Patch is fairly self-explainatory. Reporter
> > confirmed the fix. Causes all kernel oplock
> > handling functions to use identical logic to
> > detect kernel oplocks being on or off.
> >
> > Please review and push if happy !
>
> Just a minor nit-pick: I find "koplocks!=NULL" easier to read than
> just "koplocks". But that might be just me, sorry.
Updated version attached that makes all code use (koplocks!=NUL).

Let me know what you think. Cheers,

        Jeremy.

0001-s3-smbd-Use-identical-logic-to-test-for-kernel-oploc.patch (4K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Fix bug #13193 - incorrect use of kernel oplock logic.

Samba - samba-technical mailing list
On Wed, Jan 03, 2018 at 12:10:54PM -0800, Jeremy Allison via samba-technical wrote:
> Updated version attached that makes all code use (koplocks!=NUL).
>
> Let me know what you think. Cheers,

Pushed, thanks!

Volker

--
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:[hidden email]