[PATCH] Fix authentication with an empty string domain

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] Fix authentication with an empty string domain

Samba - samba-technical mailing list
Hi,

I noticed a a little while back (as it appeared to be required for the
auto-configure tool in the Windows Protocol test-suites) that we no
longer allow '' as our domain, which used to be allowed in Samba 4.6.
Attached is a fix which solved the immediate issue, and appears to
restore the 4.6 behaviour. Both tests I wrote, one using SamLogonEx
against the NETLOGON server and another binding against LDAP failed on
master, but pass on Windows 2012 R2 and with this patch. I also ran the
NETLOGON test against 4.6 to confirm that this indeed did not used to fail.


A bit more discussion on the bug:

https://bugzilla.samba.org/show_bug.cgi?id=13206


Cheers,

Garming


patch.txt (10K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Fix authentication with an empty string domain

Samba - samba-technical mailing list
On Tue, 2018-01-09 at 12:12 +1300, Garming Sam via samba-technical
wrote:

> Hi,
>
> I noticed a a little while back (as it appeared to be required for the
> auto-configure tool in the Windows Protocol test-suites) that we no
> longer allow '' as our domain, which used to be allowed in Samba 4.6.
> Attached is a fix which solved the immediate issue, and appears to
> restore the 4.6 behaviour. Both tests I wrote, one using SamLogonEx
> against the NETLOGON server and another binding against LDAP failed on
> master, but pass on Windows 2012 R2 and with this patch. I also ran the
> NETLOGON test against 4.6 to confirm that this indeed did not used to fail.
>
>
> A bit more discussion on the bug:
>
> https://bugzilla.samba.org/show_bug.cgi?id=13206

Reviewed-by: Andrew Bartlett <[hidden email]>

Please push when you you have addressed metze's concerns.

Andrew Bartlett
--
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba