[PATCH] Fix an error return

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] Fix an error return

Samba - samba-technical mailing list
Hi!

Review appreciated!

Thanks, Volker

--
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:[hidden email]

patch.txt (869 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Fix an error return

Samba - samba-technical mailing list
On Tue, Sep 05, 2017 at 04:44:45PM +0200, Volker Lendecke via samba-technical wrote:
> Hi!
>
> Review appreciated!

LGTM. Pushed !

> --
> SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
> phone: +49-551-370000-0, fax: +49-551-370000-9
> AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
> http://www.sernet.de, mailto:[hidden email]

> From d8bc351442bc1b79b4bf3daa432946b4f481f303 Mon Sep 17 00:00:00 2001
> From: Volker Lendecke <[hidden email]>
> Date: Tue, 5 Sep 2017 16:43:18 +0200
> Subject: [PATCH] cli_credentials: Fix a return value
>
> Signed-off-by: Volker Lendecke <[hidden email]>
> ---
>  auth/credentials/credentials.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/auth/credentials/credentials.c b/auth/credentials/credentials.c
> index 2342d7253cc..152df96ac75 100644
> --- a/auth/credentials/credentials.c
> +++ b/auth/credentials/credentials.c
> @@ -534,7 +534,7 @@ _PUBLIC_ struct samr_Password *cli_credentials_get_nt_hash(struct cli_credential
>    password, password_len);
>   if (converted != sizeof(nt_hash->hash)) {
>   TALLOC_FREE(nt_hash);
> - return false;
> + return NULL;
>   }
>   } else {
>   E_md4hash(password, nt_hash->hash);
> --
> 2.11.0
>