[PATCH] Fix a possible memory leak in libads

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] Fix a possible memory leak in libads

Andreas Schneider-15
Review and push much appreciated.


Thanks,


        Andreas

--
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             [hidden email]
www.samba.org

0001-s3-libads-Do-not-leak-the-msg-on-error.patch (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Fix a possible memory leak in libads

Ralph Böhme-2
On Wed, Mar 08, 2017 at 08:39:09AM +0100, Andreas Schneider wrote:
> Review and push much appreciated.

pushed.

Cheerio!
-slow

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Fix a possible memory leak in libads

Volker Lendecke-3
In reply to this post by Andreas Schneider-15
On Wed, Mar 08, 2017 at 08:39:09AM +0100, Andreas Schneider wrote:
> Review and push much appreciated.

Question: Shouldn't we do that in ads_do_paged_search_args?

Volker

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Fix a possible memory leak in libads

Ralph Böhme-2
On Wed, Mar 08, 2017 at 08:53:35AM +0100, Volker Lendecke wrote:
> On Wed, Mar 08, 2017 at 08:39:09AM +0100, Andreas Schneider wrote:
> > Review and push much appreciated.
>
> Question: Shouldn't we do that in ads_do_paged_search_args?

that should be possible and more correct I guess. Andreas?

Cancelled my autobuild.

Cheerio!
-slow

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Fix a possible memory leak in libads

Andreas Schneider-15
In reply to this post by Volker Lendecke-3
On Wednesday, 8 March 2017 08:53:35 CET Volker Lendecke wrote:
> On Wed, Mar 08, 2017 at 08:39:09AM +0100, Andreas Schneider wrote:
> > Review and push much appreciated.
>
> Question: Shouldn't we do that in ads_do_paged_search_args?

Yes, maybe that is a better approach. Here is the patch for it.


        Andreas

--
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             [hidden email]
www.samba.org

0001-s3-libads-Do-not-leak-the-msg-on-error.patch (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Fix a possible memory leak in libads

Ralph Böhme-2
On Wed, Mar 08, 2017 at 09:04:01AM +0100, Andreas Schneider wrote:
> On Wednesday, 8 March 2017 08:53:35 CET Volker Lendecke wrote:
> > On Wed, Mar 08, 2017 at 08:39:09AM +0100, Andreas Schneider wrote:
> > > Review and push much appreciated.
> >
> > Question: Shouldn't we do that in ads_do_paged_search_args?
>
> Yes, maybe that is a better approach. Here is the patch for it.

thanks! Pushed.

Cheerio!
-slow