[PATCH] Enhancement for gencache Systemtap script

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[PATCH] Enhancement for gencache Systemtap script

Samba - samba-technical mailing list
Hi!

Attached is a patcht that adds gencache hits/misses stats to the gencache
systemtap script.

I'm adding a "negative cache hit" metric for the deletion markers in
gencache_notrans. Guess that makes sense in the way that it indicates we avoided
to look into the expensive txn based gencache.

Please review&push if happy.

-slow
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] Enhancement for gencache Systemtap script

Samba - samba-technical mailing list
On Wed, Jul 26, 2017 at 02:37:37PM +0200, Ralph Böhme via samba-technical wrote:
> Attached is a patcht that adds gencache hits/misses stats to the gencache
> systemtap script.
>
> I'm adding a "negative cache hit" metric for the deletion markers in
> gencache_notrans. Guess that makes sense in the way that it indicates we avoided
> to look into the expensive txn based gencache.
>
> Please review&push if happy.

*ping*

Thanks!
-slow

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] Enhancement for gencache Systemtap script

Samba - samba-technical mailing list
On Wed, Aug 09, 2017 at 03:52:18PM +0200, Ralph Böhme wrote:

> On Wed, Jul 26, 2017 at 02:37:37PM +0200, Ralph Böhme via samba-technical wrote:
> > Attached is a patcht that adds gencache hits/misses stats to the gencache
> > systemtap script.
> >
> > I'm adding a "negative cache hit" metric for the deletion markers in
> > gencache_notrans. Guess that makes sense in the way that it indicates we avoided
> > to look into the expensive txn based gencache.
> >
> > Please review&push if happy.
>
> *ping*

metze gave his ack, will push later.

Cheerio!
-slow

Loading...