[PATCH] Display computer symbol in MacOs Finder when using vfs_fruit

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[PATCH] Display computer symbol in MacOs Finder when using vfs_fruit

Samba - samba-technical mailing list
Hi,

please review and push.

Thanks,
Guenther

--
Günther Deschner                    GPG-ID: 8EE11688
Red Hat                         [hidden email]
Samba Team                              [hidden email]

mac.patch (2K) Download Attachment
signature.asc (208 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] Display computer symbol in MacOs Finder when using vfs_fruit

Samba - samba-technical mailing list
On Thu, Jul 06, 2017 at 05:54:07PM +0200, Günther Deschner wrote:
> please review and push.

nice! Pushed.

Cheerio!
-slow

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] Display computer symbol in MacOs Finder when using vfs_fruit

Samba - samba-technical mailing list
On Sun, Jul 09, 2017 at 01:45:03PM +0200, Ralph Böhme wrote:
> On Thu, Jul 06, 2017 at 05:54:07PM +0200, Günther Deschner wrote:
> > please review and push.
>
> nice! Pushed.

failed:

Renaming directory without AAPL, must fail
Enabling AAPL
Comparing returned AAPL capabilities
WARNING!: ../source4/torture/vfs/fruit.c:1255: Expression `aapl->data.length == 50' failed: bad AAPL size
UNEXPECTED(failure): samba3.vfs.fruit metadata_netatalk.rename_dir_openfile(nt4_dc)
REASON: Exception: Exception: ../source4/torture/vfs/fruit.c:2889: Expression
`ret == 1' failed: enable_aapl failed

Attached updated patch fixes the AAPL ctx size check. Please review & push if happy.

Cheerio!
-slow
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] Display computer symbol in MacOs Finder when using vfs_fruit

Samba - samba-technical mailing list
Hi Ralph,

arg, sorry for breaking make test earlier.. Thanks for the followup
patch. Pushed to autobuild.

Thanks!
Guenther

On 09/07/17 15:55, Ralph Böhme via samba-technical wrote:

> On Sun, Jul 09, 2017 at 01:45:03PM +0200, Ralph Böhme wrote:
>> On Thu, Jul 06, 2017 at 05:54:07PM +0200, Günther Deschner wrote:
>>> please review and push.
>>
>> nice! Pushed.
>
> failed:
>
> Renaming directory without AAPL, must fail
> Enabling AAPL
> Comparing returned AAPL capabilities
> WARNING!: ../source4/torture/vfs/fruit.c:1255: Expression `aapl->data.length == 50' failed: bad AAPL size
> UNEXPECTED(failure): samba3.vfs.fruit metadata_netatalk.rename_dir_openfile(nt4_dc)
> REASON: Exception: Exception: ../source4/torture/vfs/fruit.c:2889: Expression
> `ret == 1' failed: enable_aapl failed
>
> Attached updated patch fixes the AAPL ctx size check. Please review & push if happy.
>
> Cheerio!
> -slow
>

--
Günther Deschner                    GPG-ID: 8EE11688
Red Hat                         [hidden email]
Samba Team                              [hidden email]


signature.asc (208 bytes) Download Attachment
Loading...