Re: [PATCH] CTDB scripting cleanup, including shellcheck fixups/avoidance
On Fri, Aug 11, 2017 at 3:05 PM, Martin Schwenke via samba-technical <
[hidden email]> wrote:
> Shell script cleanups, mostly to handle some new shellcheck hits that
> appeared with the latest version of shellcheck. Also, fixes for some
> other issues we have noticed.
> There is still one failure when running CTDB's shellcheck testsuite,
> due to a regression in shellcheck:
> https://github.com/koalaman/shellcheck/issues/950 >
> The fix has been merged. Just avoid shellcheck versions 0.4.5 and
> 0.4.6 when running against CTDB. ;-)
> CTDB's shellcheck testsuite still excludes several shellcheck codes.
> These appeared some time ago and were too painful to deal with.
> Hopefully I'll do something about them some time.
> Please review and maybe push...
> peace & happiness,