[PATCH] Add virtualWDigestxx attributes to samba-tool user getpasswd

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] Add virtualWDigestxx attributes to samba-tool user getpasswd

Samba - samba-technical mailing list
Adds virtual attributes virtualWDigest01 to virtualWDigest29, allowing
access to the hashes stored in supplementalCredentials Primary:WDigest.

See 3.1.1.8.11.3.1 WDIGEST_CREDENTIALS Construction
    https://msdn.microsoft.com/en-us/library/cc245680.aspx
for details

Review and push appreciated

Gary

0001-samba-tool-user-Tests-for-virtualWDigest-attributes.patch (7K) Download Attachment
0002-samba-tool-user-Support-for-virtualWDigest-attribute.patch (5K) Download Attachment
signature.asc (484 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Add virtualWDigestxx attributes to samba-tool user getpasswd

Samba - samba-technical mailing list
Hi Gary,

> Adds virtual attributes virtualWDigest01 to virtualWDigest29, allowing
> access to the hashes stored in supplementalCredentials Primary:WDigest.
>
> See 3.1.1.8.11.3.1 WDIGEST_CREDENTIALS Construction
>     https://msdn.microsoft.com/en-us/library/cc245680.aspx
> for details
>
> Review and push appreciated

If you change

+for x in range(1,30):

into

+for x in range(1, 30):

and

virtualWDigestnn:

into

virtualWDigestNN:

(in two places).

Reviewed-by: me

Thanks!
metze


signature.asc (853 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Add virtualWDigestxx attributes to samba-tool user getpasswd

Samba - samba-technical mailing list
Updated patch set attached.

Gary

On 09/05/17 16:34, Stefan Metzmacher via samba-technical wrote:

> Hi Gary,
>
>> Adds virtual attributes virtualWDigest01 to virtualWDigest29, allowing
>> access to the hashes stored in supplementalCredentials Primary:WDigest.
>>
>> See 3.1.1.8.11.3.1 WDIGEST_CREDENTIALS Construction
>>     https://msdn.microsoft.com/en-us/library/cc245680.aspx
>> for details
>>
>> Review and push appreciated
>
> If you change
>
> +for x in range(1,30):
>
> into
>
> +for x in range(1, 30):
>
> and
>
> virtualWDigestnn:
>
> into
>
> virtualWDigestNN:
>
> (in two places).
>
> Reviewed-by: me
>
> Thanks!
> metze
>

0001-samba-tool-user-Tests-for-virtualWDigest-attributes.patch (7K) Download Attachment
0002-samba-tool-user-Support-for-virtualWDigest-attribute.patch (5K) Download Attachment
signature.asc (484 bytes) Download Attachment