[PATCH] Add documentation tags to systemd service files

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] Add documentation tags to systemd service files

Samba - samba-technical mailing list
Hi,

see attached.

Please review and push if OK.


Thanks,


        Andreas

--
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             [hidden email]
www.samba.org

systemd_add_documentation_tags.patch1.txt (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

RE: [PATCH] Add documentation tags to systemd service files

Samba - samba-technical mailing list
Hai Andreas,

Now, im not a team member, but..  Small question.

nmb.service has   Wants=network-online.target
samba.service has Wants=network-online.target

winbind.service not, why?
Could you give small explanation why winbind.service is not after network-online for my understanding.
What happens if a server starts, network.target is reached and no network is getting up.
A computer pass changes and winbind is unable to update the keytab..
Things like that is what i was thinking off.


Greetz,

Louis

 

> -----Oorspronkelijk bericht-----
> Van: samba-technical
> [mailto:[hidden email]] Namens
> Andreas Schneider via samba-technical
> Verzonden: woensdag 3 januari 2018 9:47
> Aan: [hidden email]
> CC: [hidden email]
> Onderwerp: [PATCH] Add documentation tags to systemd service files
>
> Hi,
>
> see attached.
>
> Please review and push if OK.
>
>
> Thanks,
>
>
> Andreas
>
> --
> Andreas Schneider                   GPG-ID: CC014E3D
> Samba Team                             [hidden email]
> www.samba.org
>


Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Add documentation tags to systemd service files

Samba - samba-technical mailing list
On Wednesday, 3 January 2018 10:03:30 CET L.P.H. van Belle via samba-technical
wrote:

> Hai Andreas,
>
> Now, im not a team member, but..  Small question.
>
> nmb.service has   Wants=network-online.target
> samba.service has Wants=network-online.target
>
> winbind.service not, why?
> Could you give small explanation why winbind.service is not after
> network-online for my understanding. What happens if a server starts,
> network.target is reached and no network is getting up. A computer pass
> changes and winbind is unable to update the keytab.. Things like that is
> what i was thinking off.

man smb.conf -> winbind offline logon


        Andreas

--
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             [hidden email]
www.samba.org



Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Add documentation tags to systemd service files

Samba - samba-technical mailing list
On 2018-01-03 at 11:37 +0100 Andreas Schneider via samba-technical sent off:
> > winbind.service not, why?
> > Could you give small explanation why winbind.service is not after
> > network-online for my understanding. What happens if a server starts,
> > network.target is reached and no network is getting up. A computer pass
> > changes and winbind is unable to update the keytab.. Things like that is
> > what i was thinking off.
>
> man smb.conf -> winbind offline logon

"Wants" is a soft dependency a la LSB "Should-Start" and "Requires" is a hard
dependency a la LSB "Required-Start", right? Given that, "Wants=network-online"
makes perfectly sense for winbind.service for me, no?

Björn

Reply | Threaded
Open this post in threaded view
|

RE: [PATCH] Add documentation tags to systemd service files

Samba - samba-technical mailing list
Exacly.
And how about detecting the network interface names and "bind interfaces"

Greetz,

Louis



> -----Oorspronkelijk bericht-----
> Van: Björn JACKE [mailto:[hidden email]]
> Verzonden: woensdag 3 januari 2018 16:55
> Aan: Andreas Schneider
> CC: [hidden email]; L.P.H. van Belle
> Onderwerp: Re: [PATCH] Add documentation tags to systemd service files
>
> On 2018-01-03 at 11:37 +0100 Andreas Schneider via
> samba-technical sent off:
> > > winbind.service not, why?
> > > Could you give small explanation why winbind.service is not after
> > > network-online for my understanding. What happens if a
> server starts,
> > > network.target is reached and no network is getting up. A
> computer pass
> > > changes and winbind is unable to update the keytab..
> Things like that is
> > > what i was thinking off.
> >
> > man smb.conf -> winbind offline logon
>
> "Wants" is a soft dependency a la LSB "Should-Start" and
> "Requires" is a hard
> dependency a la LSB "Required-Start", right? Given that,
> "Wants=network-online"
> makes perfectly sense for winbind.service for me, no?
>
> Björn
>
>


Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Add documentation tags to systemd service files

Samba - samba-technical mailing list
In reply to this post by Samba - samba-technical mailing list
On Wednesday, 3 January 2018 16:54:46 CET Björn JACKE wrote:

> On 2018-01-03 at 11:37 +0100 Andreas Schneider via samba-technical sent off:
> > > winbind.service not, why?
> > > Could you give small explanation why winbind.service is not after
> > > network-online for my understanding. What happens if a server starts,
> > > network.target is reached and no network is getting up. A computer pass
> > > changes and winbind is unable to update the keytab.. Things like that is
> > > what i was thinking off.
> >
> > man smb.conf -> winbind offline logon
>
> "Wants" is a soft dependency a la LSB "Should-Start" and "Requires" is a
> hard dependency a la LSB "Required-Start", right? Given that,
> "Wants=network-online" makes perfectly sense for winbind.service for me,
> no?

Winbind should just be started if the network is up, that's why it has:

After=network.target

That provides the basics we need to start winbind and have it functional for
login. If we delay the start of winbind the user might try to login but it
fails because there is not network ever coming up. He might not be connected
at all ...


--
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             [hidden email]
www.samba.org



Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Add documentation tags to systemd service files

Samba - samba-technical mailing list
On 2018-01-03 at 17:34 +0100 Andreas Schneider via samba-technical sent off:
> Winbind should just be started if the network is up, that's why it has:
>
> After=network.target
>
> That provides the basics we need to start winbind and have it functional for
> login. If we delay the start of winbind the user might try to login but it
> fails because there is not network ever coming up. He might not be connected
> at all ...

the naming for that are a bit irritating but that sounds right now. But isn't
After=network.target then also what we want for the samba.service? The DC might
also not always be on a plugged network and it should start always IMHO. Also
local services might depend on it for example.

Björn
--
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:[hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Add documentation tags to systemd service files

Samba - samba-technical mailing list
On Wednesday, 3 January 2018 17:51:56 CET Björn JACKE wrote:

> On 2018-01-03 at 17:34 +0100 Andreas Schneider via samba-technical sent off:
> > Winbind should just be started if the network is up, that's why it has:
> >
> > After=network.target
> >
> > That provides the basics we need to start winbind and have it functional
> > for login. If we delay the start of winbind the user might try to login
> > but it fails because there is not network ever coming up. He might not be
> > connected at all ...
>
> the naming for that are a bit irritating but that sounds right now. But
> isn't After=network.target then also what we want for the samba.service?
> The DC might also not always be on a plugged network and it should start
> always IMHO. Also local services might depend on it for example.

We added network-online.service because the DC doesn't start if it isn't
running:

https://bugzilla.redhat.com/show_bug.cgi?id=1496307



--
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             [hidden email]
www.samba.org