[PATCH] Add a simple test to verify pam_winbind can authenticate a user

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[PATCH] Add a simple test to verify pam_winbind can authenticate a user

Samba - samba-technical mailing list
Hi,

attached is a patch which uses pam_wrapper [1] to add at least a simple test
for pam_winbind.

I don't have more time to work on that right now. I hope other will help
extending it. As you can see a simple PAM test is basically just 3 lines of
code.


Review and push much appreciated!


Thanks,


        Andreas


[1] https://cwrap.org/pam_wrapper.html

--
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             [hidden email]
www.samba.org

test_pam_winbind.patch (93K) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] Add a simple test to verify pam_winbind can authenticate a user

Samba - samba-technical mailing list
On 04/05/2017 06:41 PM, Andreas Schneider via samba-technical wrote:

> Hi,
>
> attached is a patch which uses pam_wrapper [1] to add at least a simple test
> for pam_winbind.
>
> I don't have more time to work on that right now. I hope other will help
> extending it. As you can see a simple PAM test is basically just 3 lines of
> code.
>
>
> Review and push much appreciated!
>
>
> Thanks,
>
>
> Andreas
>
>
> [1] https://cwrap.org/pam_wrapper.html
>
That landed and broke my build after successful configure because I
didn't have pam-devel installed.

Thanks,
Uri.

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] Add a simple test to verify pam_winbind can authenticate a user

Samba - samba-technical mailing list
On Saturday, 8 April 2017 19:53:41 CEST Uri Simchoni wrote:

> On 04/05/2017 06:41 PM, Andreas Schneider via samba-technical wrote:
> > Hi,
> >
> > attached is a patch which uses pam_wrapper [1] to add at least a simple
> > test for pam_winbind.
> >
> > I don't have more time to work on that right now. I hope other will help
> > extending it. As you can see a simple PAM test is basically just 3 lines
> > of
> > code.
> >
> >
> > Review and push much appreciated!
> >
> >
> > Thanks,
> >
> > Andreas
> >
> > [1] https://cwrap.org/pam_wrapper.html
>
> That landed and broke my build after successful configure because I
> didn't have pam-devel installed.

Could you try with this patch?


        Andreas

--
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             [hidden email]
www.samba.org

0001-waf-Only-build-pam_wrapper-if-we-build-with-pam.patch (2K) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] Add a simple test to verify pam_winbind can authenticate a user

Samba - samba-technical mailing list
On 04/10/2017 08:51 AM, Andreas Schneider wrote:

> On Saturday, 8 April 2017 19:53:41 CEST Uri Simchoni wrote:
>> On 04/05/2017 06:41 PM, Andreas Schneider via samba-technical wrote:
>>> Hi,
>>>
>>> attached is a patch which uses pam_wrapper [1] to add at least a simple
>>> test for pam_winbind.
>>>
>>> I don't have more time to work on that right now. I hope other will help
>>> extending it. As you can see a simple PAM test is basically just 3 lines
>>> of
>>> code.
>>>
>>>
>>> Review and push much appreciated!
>>>
>>>
>>> Thanks,
>>>
>>> Andreas
>>>
>>> [1] https://cwrap.org/pam_wrapper.html
>>
>> That landed and broke my build after successful configure because I
>> didn't have pam-devel installed.
>
>
> Could you try with this patch?
>
>
> Andreas
>
Nope. still failed. Adding/squashing the attached is one way to go...

Thanks,
Uri.

pam-fix.patch.txt (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] Add a simple test to verify pam_winbind can authenticate a user

Samba - samba-technical mailing list
On Wednesday, 12 April 2017 09:25:02 CEST Uri Simchoni wrote:

> On 04/10/2017 08:51 AM, Andreas Schneider wrote:
> > On Saturday, 8 April 2017 19:53:41 CEST Uri Simchoni wrote:
> >> On 04/05/2017 06:41 PM, Andreas Schneider via samba-technical wrote:
> >>> Hi,
> >>>
> >>> attached is a patch which uses pam_wrapper [1] to add at least a simple
> >>> test for pam_winbind.
> >>>
> >>> I don't have more time to work on that right now. I hope other will help
> >>> extending it. As you can see a simple PAM test is basically just 3 lines
> >>> of
> >>> code.
> >>>
> >>>
> >>> Review and push much appreciated!
> >>>
> >>>
> >>> Thanks,
> >>>
> >>> Andreas
> >>>
> >>> [1] https://cwrap.org/pam_wrapper.html
> >>
> >> That landed and broke my build after successful configure because I
> >> didn't have pam-devel installed.
> >
> > Could you try with this patch?
> >
> > Andreas
>
> Nope. still failed. Adding/squashing the attached is one way to go...
>
> Thanks,
> Uri.

I think this should be a patch on its own.

--
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             [hidden email]
www.samba.org

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] Add a simple test to verify pam_winbind can authenticate a user

Samba - samba-technical mailing list
On 04/12/2017 10:29 AM, Andreas Schneider wrote:

> On Wednesday, 12 April 2017 09:25:02 CEST Uri Simchoni wrote:
>> On 04/10/2017 08:51 AM, Andreas Schneider wrote:
>>> On Saturday, 8 April 2017 19:53:41 CEST Uri Simchoni wrote:
>>>> On 04/05/2017 06:41 PM, Andreas Schneider via samba-technical wrote:
>>>>> Hi,
>>>>>
>>>>> attached is a patch which uses pam_wrapper [1] to add at least a simple
>>>>> test for pam_winbind.
>>>>>
>>>>> I don't have more time to work on that right now. I hope other will help
>>>>> extending it. As you can see a simple PAM test is basically just 3 lines
>>>>> of
>>>>> code.
>>>>>
>>>>>
>>>>> Review and push much appreciated!
>>>>>
>>>>>
>>>>> Thanks,
>>>>>
>>>>> Andreas
>>>>>
>>>>> [1] https://cwrap.org/pam_wrapper.html
>>>>
>>>> That landed and broke my build after successful configure because I
>>>> didn't have pam-devel installed.
>>>
>>> Could you try with this patch?
>>>
>>> Andreas
>>
>> Nope. still failed. Adding/squashing the attached is one way to go...
>>
>> Thanks,
>> Uri.
>
> I think this should be a patch on its own.
>
Well, In that case I can RB+ your patch, and here's the same patch with
a better commit message. It doesn't change behavior a bit, but not in a
surprising manner :)

Thanks,
Uri.

pam-fix-v2.patch.txt (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] Add a simple test to verify pam_winbind can authenticate a user

Samba - samba-technical mailing list
On Wednesday, 12 April 2017 09:37:59 CEST Uri Simchoni wrote:

> On 04/12/2017 10:29 AM, Andreas Schneider wrote:
> > On Wednesday, 12 April 2017 09:25:02 CEST Uri Simchoni wrote:
> >> On 04/10/2017 08:51 AM, Andreas Schneider wrote:
> >>> On Saturday, 8 April 2017 19:53:41 CEST Uri Simchoni wrote:
> >>>> On 04/05/2017 06:41 PM, Andreas Schneider via samba-technical wrote:
> >>>>> Hi,
> >>>>>
> >>>>> attached is a patch which uses pam_wrapper [1] to add at least a
> >>>>> simple
> >>>>> test for pam_winbind.
> >>>>>
> >>>>> I don't have more time to work on that right now. I hope other will
> >>>>> help
> >>>>> extending it. As you can see a simple PAM test is basically just 3
> >>>>> lines
> >>>>> of
> >>>>> code.
> >>>>>
> >>>>>
> >>>>> Review and push much appreciated!
> >>>>>
> >>>>>
> >>>>> Thanks,
> >>>>>
> >>>>> Andreas
> >>>>>
> >>>>> [1] https://cwrap.org/pam_wrapper.html
> >>>>
> >>>> That landed and broke my build after successful configure because I
> >>>> didn't have pam-devel installed.
> >>>
> >>> Could you try with this patch?
> >>>
> >>> Andreas
> >>
> >> Nope. still failed. Adding/squashing the attached is one way to go...
> >>
> >> Thanks,
> >> Uri.
> >
> > I think this should be a patch on its own.
>
> Well, In that case I can RB+ your patch, and here's the same patch with
> a better commit message. It doesn't change behavior a bit, but not in a
> surprising manner :)

RB+

Can you push both patches?


Thanks,


        Andreas

--
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             [hidden email]
www.samba.org

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] Add a simple test to verify pam_winbind can authenticate a user

Samba - samba-technical mailing list
On 04/12/2017 10:59 AM, Andreas Schneider wrote:

> On Wednesday, 12 April 2017 09:37:59 CEST Uri Simchoni wrote:
>> On 04/12/2017 10:29 AM, Andreas Schneider wrote:
>>> On Wednesday, 12 April 2017 09:25:02 CEST Uri Simchoni wrote:
>>>> On 04/10/2017 08:51 AM, Andreas Schneider wrote:
>>>>> On Saturday, 8 April 2017 19:53:41 CEST Uri Simchoni wrote:
>>>>>> On 04/05/2017 06:41 PM, Andreas Schneider via samba-technical wrote:
>>>>>>> Hi,
>>>>>>>
>>>>>>> attached is a patch which uses pam_wrapper [1] to add at least a
>>>>>>> simple
>>>>>>> test for pam_winbind.
>>>>>>>
>>>>>>> I don't have more time to work on that right now. I hope other will
>>>>>>> help
>>>>>>> extending it. As you can see a simple PAM test is basically just 3
>>>>>>> lines
>>>>>>> of
>>>>>>> code.
>>>>>>>
>>>>>>>
>>>>>>> Review and push much appreciated!
>>>>>>>
>>>>>>>
>>>>>>> Thanks,
>>>>>>>
>>>>>>> Andreas
>>>>>>>
>>>>>>> [1] https://cwrap.org/pam_wrapper.html
>>>>>>
>>>>>> That landed and broke my build after successful configure because I
>>>>>> didn't have pam-devel installed.
>>>>>
>>>>> Could you try with this patch?
>>>>>
>>>>> Andreas
>>>>
>>>> Nope. still failed. Adding/squashing the attached is one way to go...
>>>>
>>>> Thanks,
>>>> Uri.
>>>
>>> I think this should be a patch on its own.
>>
>> Well, In that case I can RB+ your patch, and here's the same patch with
>> a better commit message. It doesn't change behavior a bit, but not in a
>> surprising manner :)
>
> RB+
>
> Can you push both patches?
>
>
> Thanks,
>
>
> Andreas
>
Done.
Thanks,
Uri.

Loading...