[PATCH] Add a prefork process model

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] Add a prefork process model

Samba - samba-technical mailing list
Patch set to add a pre-fork process model

Reviews appreciated
Gary

prefork_process_model.patch.txt (150K) Download Attachment
signature.asc (484 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Add a prefork process model

Samba - samba-technical mailing list
On 09/18/2017 11:13 PM, Gary Lockyer via samba-technical wrote:
> Patch set to add a pre-fork process model
>
> Reviews appreciated
> Gary
>


> This option controls the number of worker processes that are
> + started for each service when prefork process model is enabled

Please correct me if I'm wrong, but isn't "process model" a
Samba-devel-internal concept?

IMO, we should try to explain this parameter to users without using
"process model" (e.g. list configurations where this applies), or
mention the process model in addition to having a "primary" definition.

Thanks,
Uri.


signature.asc (484 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Add a prefork process model

Samba - samba-technical mailing list
On Tue, 2017-09-19 at 06:55 +0300, Uri Simchoni via samba-technical
wrote:

> On 09/18/2017 11:13 PM, Gary Lockyer via samba-technical wrote:
> > Patch set to add a pre-fork process model
> >
> > Reviews appreciated
> > Gary
> >
>
>
> > This option controls the number of worker processes that are
> > + started for each service when prefork process
> > model is enabled
>
> Please correct me if I'm wrong, but isn't "process model" a
> Samba-devel-internal concept?

Sort of.  It is a concept that extends beyond Samba from Apache HTTPD,
eg:

http://httpd.apache.org/dev/whiteboard/process-model.html
http://httpd.apache.org/docs/2.2/mod/

It maps to this option to 'samba':
-M, --model=MODEL                  Select process model

Naturally better text would be most helpful in both spots, if you have
some ideas.

Thanks,

Andrew Bartlett
--
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT  
https://catalyst.net.nz/services/samba





Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Add a prefork process model

Samba - samba-technical mailing list
On 09/19/2017 07:03 AM, Andrew Bartlett wrote:

> On Tue, 2017-09-19 at 06:55 +0300, Uri Simchoni via samba-technical
> wrote:
>> On 09/18/2017 11:13 PM, Gary Lockyer via samba-technical wrote:
>>> Patch set to add a pre-fork process model
>>>
>>> Reviews appreciated
>>> Gary
>>>
>>
>>
>>> This option controls the number of worker processes that are
>>> + started for each service when prefork process
>>> model is enabled
>>
>> Please correct me if I'm wrong, but isn't "process model" a
>> Samba-devel-internal concept?
>
> Sort of.  It is a concept that extends beyond Samba from Apache HTTPD,
> eg:
>
> http://httpd.apache.org/dev/whiteboard/process-model.html
> http://httpd.apache.org/docs/2.2/mod/
>
> It maps to this option to 'samba':
> -M, --model=MODEL                  Select process model
>
> Naturally better text would be most helpful in both spots, if you have
> some ideas.
>

To be perfectly honest, I have only a vague idea of what "process model"
is. Having to know this never was part of my Samba work. One time I got
curious (maybe because for me, "Standard Model" is a term from particle
physics), so I skimmed Wiki and past mailing list threads and couldn't
find a useful answer. So this is why when a new patch set introducing a
new process model appeared, I had a look at the additions to the man
page and what I found was somewhat tautological. I hope you can see my
frustration - this is not nitpicking.

I now see we have a rather useful definition in the samba.8 man page
(maybe it is incomplete but it sets the context). Reading that
definition helped me understand (hopefully) what the "prefork process
model" is all about. So what I'd like to propose is that "prefork" gets
covered in the samba.8 manpage (perhaps mentioning that only ldap
supports it and with other services it decays into single), and add a
reference to that on smb.conf.5.

Thanks,
Uri.
> Thanks,
>
> Andrew Bartlett
>


Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Add a prefork process model

Samba - samba-technical mailing list
Updated patch set attached, adds documentation of the process models to
man 8 samba.

Reviews greatly appreciated, I'd like to get this one finished.

Thanks
Gary

On 19/09/17 17:11, Uri Simchoni via samba-technical wrote:

> On 09/19/2017 07:03 AM, Andrew Bartlett wrote:
>> On Tue, 2017-09-19 at 06:55 +0300, Uri Simchoni via samba-technical
>> wrote:
>>> On 09/18/2017 11:13 PM, Gary Lockyer via samba-technical wrote:
>>>> Patch set to add a pre-fork process model
>>>>
>>>> Reviews appreciated
>>>> Gary
>>>>
>>>
>>>
>>>> This option controls the number of worker processes that are
>>>> + started for each service when prefork process
>>>> model is enabled
>>>
>>> Please correct me if I'm wrong, but isn't "process model" a
>>> Samba-devel-internal concept?
>>
>> Sort of.  It is a concept that extends beyond Samba from Apache HTTPD,
>> eg:
>>
>> http://httpd.apache.org/dev/whiteboard/process-model.html
>> http://httpd.apache.org/docs/2.2/mod/
>>
>> It maps to this option to 'samba':
>> -M, --model=MODEL                  Select process model
>>
>> Naturally better text would be most helpful in both spots, if you have
>> some ideas.
>>
>
> To be perfectly honest, I have only a vague idea of what "process model"
> is. Having to know this never was part of my Samba work. One time I got
> curious (maybe because for me, "Standard Model" is a term from particle
> physics), so I skimmed Wiki and past mailing list threads and couldn't
> find a useful answer. So this is why when a new patch set introducing a
> new process model appeared, I had a look at the additions to the man
> page and what I found was somewhat tautological. I hope you can see my
> frustration - this is not nitpicking.
>
> I now see we have a rather useful definition in the samba.8 man page
> (maybe it is incomplete but it sets the context). Reading that
> definition helped me understand (hopefully) what the "prefork process
> model" is all about. So what I'd like to propose is that "prefork" gets
> covered in the samba.8 manpage (perhaps mentioning that only ldap
> supports it and with other services it decays into single), and add a
> reference to that on smb.conf.5.
>
> Thanks,
> Uri.
>> Thanks,
>>
>> Andrew Bartlett
>>
>
>

prefork_process_model.patch.txt (152K) Download Attachment
signature.asc (484 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Add a prefork process model

Samba - samba-technical mailing list
Could I get comments or another another team review on this.

Thanks
Gary.

On 26/09/17 07:32, Gary Lockyer via samba-technical wrote:

> Updated patch set attached, adds documentation of the process models to
> man 8 samba.
>
> Reviews greatly appreciated, I'd like to get this one finished.
>
> Thanks
> Gary
>
> On 19/09/17 17:11, Uri Simchoni via samba-technical wrote:
>> On 09/19/2017 07:03 AM, Andrew Bartlett wrote:
>>> On Tue, 2017-09-19 at 06:55 +0300, Uri Simchoni via samba-technical
>>> wrote:
>>>> On 09/18/2017 11:13 PM, Gary Lockyer via samba-technical wrote:
>>>>> Patch set to add a pre-fork process model
>>>>>
>>>>> Reviews appreciated
>>>>> Gary
>>>>>
>>>>
>>>>
>>>>> This option controls the number of worker processes that are
>>>>> + started for each service when prefork process
>>>>> model is enabled
>>>>
>>>> Please correct me if I'm wrong, but isn't "process model" a
>>>> Samba-devel-internal concept?
>>>
>>> Sort of.  It is a concept that extends beyond Samba from Apache HTTPD,
>>> eg:
>>>
>>> http://httpd.apache.org/dev/whiteboard/process-model.html
>>> http://httpd.apache.org/docs/2.2/mod/
>>>
>>> It maps to this option to 'samba':
>>> -M, --model=MODEL                  Select process model
>>>
>>> Naturally better text would be most helpful in both spots, if you have
>>> some ideas.
>>>
>>
>> To be perfectly honest, I have only a vague idea of what "process model"
>> is. Having to know this never was part of my Samba work. One time I got
>> curious (maybe because for me, "Standard Model" is a term from particle
>> physics), so I skimmed Wiki and past mailing list threads and couldn't
>> find a useful answer. So this is why when a new patch set introducing a
>> new process model appeared, I had a look at the additions to the man
>> page and what I found was somewhat tautological. I hope you can see my
>> frustration - this is not nitpicking.
>>
>> I now see we have a rather useful definition in the samba.8 man page
>> (maybe it is incomplete but it sets the context). Reading that
>> definition helped me understand (hopefully) what the "prefork process
>> model" is all about. So what I'd like to propose is that "prefork" gets
>> covered in the samba.8 manpage (perhaps mentioning that only ldap
>> supports it and with other services it decays into single), and add a
>> reference to that on smb.conf.5.
>>
>> Thanks,
>> Uri.
>>> Thanks,
>>>
>>> Andrew Bartlett
>>>
>>
>>


signature.asc (484 bytes) Download Attachment