IPC$ entries not deleted from connections.tdb?

[Yannick Bergeron]

Hi Andrew,

I know that you're a very busy guy, but I've CC you on this post a few days
ago and didn't get any answer.

http://lists.samba.org/archive/samba-technical/2005-April/040377.html
http://lists.samba.org/archive/samba-technical/2005-April/040378.html
http://lists.samba.org/archive/samba-technical/2005-April/040379.html
http://lists.samba.org/archive/samba/2005-April/104135.html

I would like to have your impression on this problem or if you can reproduce
it.

I would be really surprised if I was the only one who has it. The difference
is that we're using samba with a lots of users and we've estimated that the
file will grow at least 55mb per month. This if for a smbd child that make
only one connection. It could be like 20 times bigger (1.1gb) if each smbd
child owns 20 connections.


Thanx

Yannick Bergeron
[hidden email]
[hidden email]


--
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/listinfo/samba

[Andrew Bartlett]

On Tue, 2005-04-26 at 15:33 -0400, Yannick Bergeron wrote:
> Hi Andrew,
>
> I know that you're a very busy guy, but I've CC you on this post a few days
> ago and didn't get any answer.

I'm not working on Samba 3.0 on a day-to-day basis - you will need to
attract someone else's attention to the issue, or better still file it
in bugzilla, if you think it's real.

Sorry,

Andrew Bartlett

--
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Student Network Administrator, Hawker College  http://hawkerc.net

--
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/listinfo/samba

[Jeremy Allison]

On Tue, Apr 26, 2005 at 03:33:11PM -0400, Yannick Bergeron wrote:

> Hi Andrew,
>
> I know that you're a very busy guy, but I've CC you on this post a few days
> ago and didn't get any answer.
>
> http://lists.samba.org/archive/samba-technical/2005-April/040377.html
> http://lists.samba.org/archive/samba-technical/2005-April/040378.html
> http://lists.samba.org/archive/samba-technical/2005-April/040379.html
> http://lists.samba.org/archive/samba/2005-April/104135.html
>
> I would like to have your impression on this problem or if you can
> reproduce it.
>
> I would be really surprised if I was the only one who has it. The
> difference is that we're using samba with a lots of users and we've
> estimated that the file will grow at least 55mb per month. This if for a
> smbd child that make only one connection. It could be like 20 times bigger
> (1.1gb) if each smbd child owns 20 connections.

There were some codepaths in smbd/service.c that didn't call yield_connection()
on an error. But they would only occur in an error case. Do you have any of these
in you smbd logs ?

Anyway, here is a patch to ensure yield_connection() is always called on error
(and also a tidyup of some extraneous macro calls).

Jeremy.

--
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/listinfo/samba

[Yannick Bergeron]

Hi Jeremy,

I've applied the patch and rebuild samba-3.0.11. The results are pretty good
as the connections.tdb file is clean and the smbstatus output seems to be
ok.

I've set the debug level to 10 and the real problem has been corrected by
this part, since I'd this debug message in my log file very often

@@ -575,6 +575,7 @@
        if (!change_to_user(conn, conn->vuid)) {
                /* No point continuing if they fail the basic checks */
                DEBUG(0,("Can't become connected user!\n"));
+ yield_connection(conn, lp_servicename(snum));
                conn_free(conn);
                *status = NT_STATUS_LOGON_FAILURE;
                return NULL;

Thanx again for your help

>From: Jeremy Allison <[hidden email]>
>Reply-To: Jeremy Allison <[hidden email]>
>To: Yannick Bergeron <[hidden email]>
>CC: [hidden email], [hidden email]
>Subject: Re: [Samba] IPC$ entries not deleted from connections.tdb?
>Date: Tue, 26 Apr 2005 16:51:33 -0700
>
>On Tue, Apr 26, 2005 at 03:33:11PM -0400, Yannick Bergeron wrote:
> > Hi Andrew,
> >
> > I know that you're a very busy guy, but I've CC you on this post a few
>days
> > ago and didn't get any answer.
> >
> > http://lists.samba.org/archive/samba-technical/2005-April/040377.html
> > http://lists.samba.org/archive/samba-technical/2005-April/040378.html
> > http://lists.samba.org/archive/samba-technical/2005-April/040379.html
> > http://lists.samba.org/archive/samba/2005-April/104135.html
> >
> > I would like to have your impression on this problem or if you can
> > reproduce it.
> >
> > I would be really surprised if I was the only one who has it. The
> > difference is that we're using samba with a lots of users and we've
> > estimated that the file will grow at least 55mb per month. This if for a
> > smbd child that make only one connection. It could be like 20 times
>bigger
> > (1.1gb) if each smbd child owns 20 connections.
>
>There were some codepaths in smbd/service.c that didn't call
>yield_connection()
>on an error. But they would only occur in an error case. Do you have any of
>these
>in you smbd logs ?
>
>Anyway, here is a patch to ensure yield_connection() is always called on
>error
>(and also a tidyup of some extraneous macro calls).
>
>Jeremy.
><< look >>

--
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/listinfo/samba