How to set share defaults for test_default_s4?

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

How to set share defaults for test_default_s4?

Samba - samba-technical mailing list
Hi!

I'd like to propose changing the default of aio read/write size to 1.
I can't get it through autobuild, because it fails in the docs-test:

[2(6)/2216 at 1s] samba.tests.docs
UNEXPECTED(failure):
samba.tests.docs.samba.tests.docs.SmbDotConfTests.test_default_s4(none)
REASON: Exception: Exception: Traceback (most recent call last):
  File "/memdisk/vlendec/W/b2281405/samba/bin/python/samba/tests/docs.py", line 172, in test_default_s4
    self._test_default(['bin/samba-tool', 'testparm'])
  File "/memdisk/vlendec/W/b2281405/samba/bin/python/samba/tests/docs.py", line 206, in _test_default
    "Parameters that do not have matching defaults:"))
AssertionError: Parameters that do not have matching defaults:

    aio read size
      Expected: 1
      Got: 0
    aio write size
      Expected: 1
      Got: 0

How do I set the defaults for the source4-based fileserver?

Thanks, Volker

--
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:[hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: How to set share defaults for test_default_s4?

Samba - samba-technical mailing list
On Mon, Dec 04, 2017 at 05:01:38PM +0100, Volker Lendecke via samba-technical wrote:
> How do I set the defaults for the source4-based fileserver?

take a look at commit dd10c820aab1c04f079c0d0f41dc176fdd5545c4 :)))

-slow

--
Ralph Boehme, Samba Team       https://samba.org/
Samba Developer, SerNet GmbH   https://sernet.de/en/samba/

Reply | Threaded
Open this post in threaded view
|

Re: How to set share defaults for test_default_s4?

Samba - samba-technical mailing list
In reply to this post by Samba - samba-technical mailing list
On Mon, 2017-12-04 at 17:01 +0100, Volker Lendecke via samba-technical
wrote:

> Hi!
>
> I'd like to propose changing the default of aio read/write size to 1.
> I can't get it through autobuild, because it fails in the docs-test:
>
> [2(6)/2216 at 1s] samba.tests.docs
> UNEXPECTED(failure):
> samba.tests.docs.samba.tests.docs.SmbDotConfTests.test_default_s4(none)
> REASON: Exception: Exception: Traceback (most recent call last):
>   File "/memdisk/vlendec/W/b2281405/samba/bin/python/samba/tests/docs.py", line 172, in test_default_s4
>     self._test_default(['bin/samba-tool', 'testparm'])
>   File "/memdisk/vlendec/W/b2281405/samba/bin/python/samba/tests/docs.py", line 206, in _test_default
>     "Parameters that do not have matching defaults:"))
> AssertionError: Parameters that do not have matching defaults:
>
>     aio read size
>       Expected: 1
>       Got: 0
>     aio write size
>       Expected: 1
>       Got: 0
>
> How do I set the defaults for the source4-based fileserver?

Those defaults are in lib/param/loadparm.c:loadparm_init()

Andrew Bartlett

--
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba


Reply | Threaded
Open this post in threaded view
|

Re: How to set share defaults for test_default_s4?

Samba - samba-technical mailing list
On Tue, Dec 05, 2017 at 06:30:17AM +1300, Andrew Bartlett via samba-technical wrote:
> > How do I set the defaults for the source4-based fileserver?
>
> Those defaults are in lib/param/loadparm.c:loadparm_init()

Thanks :-)

Volker

--
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:[hidden email]