DO NOT REPLY [Bug 7123] New: Use both old dest file and partial file as basis data

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

DO NOT REPLY [Bug 7123] New: Use both old dest file and partial file as basis data

samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=7123

           Summary: Use both old dest file and partial file as basis data
           Product: rsync
           Version: 3.1.0
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: enhancement
          Priority: P3
         Component: core
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]
         QAContact: [hidden email]


From http://lists.samba.org/archive/rsync/2009-December/024382.html :

Currently, a file transfer can use only basis file: the old destination file,
the file in the partial dir, or an alternate basis from somewhere.  This makes
it difficult to complete the delta-transfer of a large file if rsync keeps
getting interrupted and has to be restarted.  If rsync transfers some literal
data (setting cleanup_got_literal) and is then interrupted, the partial file
will be kept, and the next run will not have the benefit of the later data in
the old destination file as basis data.

At a minimum, rsync should use both the old destination file and the partial
file as basis data.  In some circumstances it might be beneficial to keep
multiple partial files rather than replacing the previous one, but I'm not sure
whether this is common enough to be worth implementing.


--
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
--
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
Reply | Threaded
Open this post in threaded view
|

DO NOT REPLY [Bug 7123] Use both old dest file and partial file as basis data

samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=7123





------- Comment #1 from [hidden email]  2010-02-20 11:15 CST -------
May I suggest using a state file?


--
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
--
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
Reply | Threaded
Open this post in threaded view
|

DO NOT REPLY [Bug 7123] Use both old dest file and partial file as basis data

samba-bugs
In reply to this post by samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=7123





------- Comment #2 from [hidden email]  2010-02-20 18:04 CST -------
Re comment #1: I don't understand what you are proposing.  Please give some
more details.


--
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
--
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
Reply | Threaded
Open this post in threaded view
|

DO NOT REPLY [Bug 7123] Use both old dest file and partial file as basis data

samba-bugs
In reply to this post by samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=7123


[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




------- Comment #3 from [hidden email]  2011-01-17 16:03 CST -------
*** Bug 7922 has been marked as a duplicate of this bug. ***


--
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
--
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
Reply | Threaded
Open this post in threaded view
|

DO NOT REPLY [Bug 7123] Use both old dest file and partial file as basis data

samba-bugs
In reply to this post by samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=7123





------- Comment #4 from [hidden email]  2011-01-18 03:38 CST -------
Is there a plan to fix this?


--
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
--
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
Reply | Threaded
Open this post in threaded view
|

DO NOT REPLY [Bug 7123] Use both old dest file and partial file as basis data

samba-bugs
In reply to this post by samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=7123





------- Comment #5 from [hidden email]  2011-02-21 07:36 CST -------
Created an attachment (id=6260)
 --> (https://bugzilla.samba.org/attachment.cgi?id=6260&action=view)
fix

i don't know what a "patch" is, but i changed this source code file and
recompiled. seems to work.

it could be done better - it could append directly to the partial file, instead
of creating the temporary merge file, then replacing the partial file.

seems to work tho.

let me know your thoughts.


--
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
--
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
Reply | Threaded
Open this post in threaded view
|

DO NOT REPLY [Bug 7123] Use both old dest file and partial file as basis data

samba-bugs
In reply to this post by samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=7123


[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
Attachment #6260 is|0                           |1
           obsolete|                            |




------- Comment #6 from [hidden email]  2011-02-21 21:30 CST -------
Created an attachment (id=6261)
 --> (https://bugzilla.samba.org/attachment.cgi?id=6261&action=view)
A patch version taken from the generator.c "fix" attachment


--
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
--
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
Reply | Threaded
Open this post in threaded view
|

[Bug 7123] Use both old dest file and partial file as basis data

Samba - rsync mailing list
In reply to this post by samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=7123

--- Comment #7 from Ben RUBSON <[hidden email]> ---
I should have a look at this.
This would complete my work in https://bugzilla.samba.org/show_bug.cgi?id=13071
to help dealing with big files.

--
You are receiving this mail because:
You are the QA Contact for the bug.

--
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
Reply | Threaded
Open this post in threaded view
|

[Bug 7123] Use both old dest file and partial file as basis data

Samba - rsync mailing list
In reply to this post by samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=7123

--- Comment #8 from Ben RUBSON <[hidden email]> ---
See https://bugzilla.samba.org/show_bug.cgi?id=13083 for a patch !

--
You are receiving this mail because:
You are the QA Contact for the bug.

--
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html