Quantcast

Code inconsistency between release version and git in rsync-3.0.9

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Code inconsistency between release version and git in rsync-3.0.9

Samba - rsync mailing list
There are huge differences between source files in the version 3.0.9
released as a tar.gz and source files in git. I  would assume that the
released version would correspond to the version in git but with 3.0.9
it is not like that. In 3.1.0 the released and git versions are more or
less the same.

So my question is, from what source files was the 3.0.9 version created?
Thank you.
Regards,

Michal Ruprich

--
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Code inconsistency between release version and git in rsync-3.0.9

Samba - rsync mailing list
On Tue, Apr 04, 2017 at 11:12:11AM +0200, Michal Ruprich via rsync wrote:
> There are huge differences between source files in the version 3.0.9
> released as a tar.gz and source files in git. I  would assume that the
> released version would correspond to the version in git but with 3.0.9
> it is not like that. In 3.1.0 the released and git versions are more or
> less the same.
How did you construct this?

I can't reproduce your result. The only differences I see are the generated
files proto.h, rsync.1, and rsyncd.conf.5.

Here's my test steps, with the output of everything except the final diffstats
omitted.

$ cd /tmp
$ tar xvf .../rsync-3.0.9.tar.gz
$ tar xvf .../rsync-3.1.0.tar.gz
$ git clone --bare git://git.samba.org/rsync.git /tmp/rsync-git-bare/
$ GIT_DIR=/tmp/rsync-git-bare git worktree add /tmp/rsync-git-3.0.9 v3.0.9
$ GIT_DIR=/tmp/rsync-git-bare git worktree add /tmp/rsync-git-3.1.0 v3.1.0
$ diff -Nuar rsync-git-3.0.9/ rsync-3.0.9/ --exclude .git --exclude-from rsync-git-3.0.9/.gitignore >rsync-git__rsync-3.0.9.diff
$ diff -Nuar rsync-git-3.1.0/ rsync-3.1.0/ --exclude .git --exclude-from rsync-git-3.1.0/.gitignore >rsync-git__rsync-3.1.0.diff
$ diffstat <rsync-git__rsync-3.0.9.diff
 proto.h       |  405 ++++++
 rsync.1       | 3585 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 rsyncd.conf.5 |  864 +++++++++++++
 3 files changed, 4854 insertions(+)
$ diffstat <rsync-git__rsync-3.1.0.diff
 proto.h       |  422 ++++++
 rsync.1       | 3958 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 rsyncd.conf.5 | 1075 +++++++++++++++
 3 files changed, 5455 insertions(+)

--
Robin Hugh Johnson
Gentoo Linux: Dev, Infra Lead, Foundation Trustee & Treasurer
E-Mail   : [hidden email]
GnuPG FP : 11ACBA4F 4778E3F6 E4EDF38E B27B944E 34884E85
GnuPG FP : 7D0B3CEB E9B85B1F 825BCECF EE05E6F6 A48F6136

--
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Code inconsistency between release version and git in rsync-3.0.9

Samba - rsync mailing list
Ok, this is my mistake. I cloned the git repo and I was looking into the
master. There is no v3.0.9 tag, the last tag for 3.0.x version is v3.0.3
in this branch. I have rsync 3.0.9 as the latest version on my system
and I was trying to determine the severity of changes between v3.0.9 and
v3.1.0. When I was looking for certain commits, I noticed that there are
changes in files that don't really fit the 3.0.9 but I never noticed
that there is a separate working tree for each 3.0.x version.

Sorry for the trouble and thanks for the clarification.


On 04/05/2017 01:36 AM, Robin H. Johnson wrote:

> On Tue, Apr 04, 2017 at 11:12:11AM +0200, Michal Ruprich via rsync wrote:
>> There are huge differences between source files in the version 3.0.9
>> released as a tar.gz and source files in git. I  would assume that the
>> released version would correspond to the version in git but with 3.0.9
>> it is not like that. In 3.1.0 the released and git versions are more or
>> less the same.
> How did you construct this?
>
> I can't reproduce your result. The only differences I see are the generated
> files proto.h, rsync.1, and rsyncd.conf.5.
>
> Here's my test steps, with the output of everything except the final diffstats
> omitted.
>
> $ cd /tmp
> $ tar xvf .../rsync-3.0.9.tar.gz
> $ tar xvf .../rsync-3.1.0.tar.gz
> $ git clone --bare git://git.samba.org/rsync.git /tmp/rsync-git-bare/
> $ GIT_DIR=/tmp/rsync-git-bare git worktree add /tmp/rsync-git-3.0.9 v3.0.9
> $ GIT_DIR=/tmp/rsync-git-bare git worktree add /tmp/rsync-git-3.1.0 v3.1.0
> $ diff -Nuar rsync-git-3.0.9/ rsync-3.0.9/ --exclude .git --exclude-from rsync-git-3.0.9/.gitignore >rsync-git__rsync-3.0.9.diff
> $ diff -Nuar rsync-git-3.1.0/ rsync-3.1.0/ --exclude .git --exclude-from rsync-git-3.1.0/.gitignore >rsync-git__rsync-3.1.0.diff
> $ diffstat <rsync-git__rsync-3.0.9.diff
>  proto.h       |  405 ++++++
>  rsync.1       | 3585 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  rsyncd.conf.5 |  864 +++++++++++++
>  3 files changed, 4854 insertions(+)
> $ diffstat <rsync-git__rsync-3.1.0.diff
>  proto.h       |  422 ++++++
>  rsync.1       | 3958 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  rsyncd.conf.5 | 1075 +++++++++++++++
>  3 files changed, 5455 insertions(+)
>


--
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
Loading...