[Bug 12755] New: [patch] Improve execution speed on Windows; with Win32 API calls

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 12755] New: [patch] Improve execution speed on Windows; with Win32 API calls

Samba - rsync mailing list
https://bugzilla.samba.org/show_bug.cgi?id=12755

            Bug ID: 12755
           Summary: [patch] Improve execution speed on Windows; with Win32
                    API calls
           Product: rsync
           Version: 3.1.3
          Hardware: All
                OS: Windows 10
            Status: NEW
          Severity: normal
          Priority: P5
         Component: core
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]

Created attachment 13169
  --> https://bugzilla.samba.org/attachment.cgi?id=13169&action=edit
Improve wall-time execution speed on Windows

The attached patch improves execution speed under Windows, by sprinkled usage
of the Win32 API. The patch is against the Git repository master branch.

When compiled with MSYS or Cygwin, this patch massively improves on total wall
time of the synchronization. By utilizing the Win32 API, I was able to bypass
lots of POSIX-to-Win32 translations occurring coupled with reusing given
stat()-equivalent data returned during the file-system directory walks.

Comments, suggestions, ideas are welcomed!

-Joe

--
You are receiving this mail because:
You are the QA Contact for the bug.

--
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
Reply | Threaded
Open this post in threaded view
|

[Bug 12755] [patch] Improve execution speed on Windows; with Win32 API calls

Samba - rsync mailing list
https://bugzilla.samba.org/show_bug.cgi?id=12755

--- Comment #1 from Joseph Benden <[hidden email]> ---
If anyone wishes to test the compiled binary, it's available for download here:

https://github.com/jbenden/rsync/releases

--
You are receiving this mail because:
You are the QA Contact for the bug.

--
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
Reply | Threaded
Open this post in threaded view
|

[Bug 12755] [patch] Improve execution speed on Windows; with Win32 API calls

Samba - rsync mailing list
In reply to this post by Samba - rsync mailing list
https://bugzilla.samba.org/show_bug.cgi?id=12755

Wayne Davison <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #13169|application/mbox            |text/plain
          mime type|                            |
  Attachment #13169|0                           |1
           is patch|                            |

--
You are receiving this mail because:
You are the QA Contact for the bug.

--
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
Reply | Threaded
Open this post in threaded view
|

[Bug 12755] [patch] Improve execution speed on Windows; with Win32 API calls

Samba - rsync mailing list
In reply to this post by Samba - rsync mailing list
https://bugzilla.samba.org/show_bug.cgi?id=12755

--- Comment #2 from Joseph Benden <[hidden email]> ---
Please disregard the patch attachment as the actual definitive solution and
rather visit my GitHub repository for the current working source and binaries.

If this solution is accepted for inclusion in to Rsync or the Rsync-Patches
repository, I will re-create a viable patch. I will also do so if asked...

See GitHub: https://github.com/jbenden/rsync/

Thank you! Comments, suggestions, and ideas are always welcomed!
-Joe

--
You are receiving this mail because:
You are the QA Contact for the bug.

--
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html