[Bug 11817] New: Fix rsyncd.conf gid field parsing: allow spaces within them and improve delimiter logic

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 11817] New: Fix rsyncd.conf gid field parsing: allow spaces within them and improve delimiter logic

samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=11817

            Bug ID: 11817
           Summary: Fix rsyncd.conf gid field parsing: allow spaces within
                    them and improve delimiter logic
           Product: rsync
           Version: 3.1.2
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5
         Component: core
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]

Created attachment 11952
  --> https://bugzilla.samba.org/attachment.cgi?id=11952&action=edit
Patch to allow spaces within group names in rsyncd.conf

We (at FreeNAS) encountered this bug when one of our users filed this bug:
https://bugs.freenas.org/issues/7950

The gist of the bug is that the user has a group named: " DOMAIN\domain admins"
in his rsync module group which irks the conf file.

Initially I just made the patch and added it to our local copy of the freebsd
ports tree used in our builds, however that is difficult to maintain and thus I
wish to submit that very same patch upstream (i.e. to you guys).

My C is not very good and thus if you find any suboptimal code in my patch, I
apologize in advance and request you to improve on it in ways you find fit.

Either ways it would be very nice to have this work properly.

Please go though path (see attached), I have tested it against the master
branch of the samba rsync git repo: "git://git.samba.org/rsync.git" and can
also submit my commit of that as a push request if there is a way to do that
(see this commit in our local copy of your rsync git repo:
https://github.com/freenas/rsync/commit/a59bd239b92dcae984c9a9579fc0cee7ec5ffa75

--
You are receiving this mail because:
You are the QA Contact for the bug.

--
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
Reply | Threaded
Open this post in threaded view
|

[Bug 11817] Fix rsyncd.conf gid field parsing: allow spaces within them and improve delimiter logic

samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=11817

Wayne Davison <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Wayne Davison <[hidden email]> ---
I've committed a different change that leaves the default comma & whitespace
parsing unchanged but allows the user to request comma-only splitting by
starting the list with a comma (see commit
9a12959ab6017a859fe8cd90ae2043b62a85b306).

--
You are receiving this mail because:
You are the QA Contact for the bug.

--
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html