[Bug 11814] New: man-copy Make target missing rsync.1 and rsyncd.conf.5 dependencies

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 11814] New: man-copy Make target missing rsync.1 and rsyncd.conf.5 dependencies

samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=11814

            Bug ID: 11814
           Summary: man-copy Make target missing rsync.1 and rsyncd.conf.5
                    dependencies
           Product: rsync
           Version: 3.1.2
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5
         Component: core
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]

I currently do not have yodl2man installed. I was building rsync from the git
repository to verify a different change. The cp commands relying on the
existence of rsync.1 and rsyncd.conf.5 failed since those files did not exist.
That man-copy target should rely on rsync.1 and rsyncd.conf.5 it seems.

--
You are receiving this mail because:
You are the QA Contact for the bug.

--
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
Reply | Threaded
Open this post in threaded view
|

[Bug 11814] man-copy Make target missing rsync.1 and rsyncd.conf.5 dependencies

samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=11814

--- Comment #1 from Brant Gurganus <[hidden email]> ---
Created attachment 11943
  --> https://bugzilla.samba.org/attachment.cgi?id=11943&action=edit
patch adding man page dependencies

This patch makes the two files dependencies triggering them to be generated.
They still fail in my case since I don't have yodl2man, but they'd be generated
if I did.

If the intention is to use the man files if there but ignore them if not, then
the patch would have to be different.

--
You are receiving this mail because:
You are the QA Contact for the bug.

--
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html
Reply | Threaded
Open this post in threaded view
|

[Bug 11814] man-copy Make target missing rsync.1 and rsyncd.conf.5 dependencies

samba-bugs
In reply to this post by samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=11814

Wayne Davison <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
             Status|NEW                         |RESOLVED

--- Comment #2 from Wayne Davison <[hidden email]> ---
The "man" target depends on the *.1 & *.5 files so that they get created. The
"man-copy" target just tries to copy pre-existing files from the srcdir (which
is useful if someone is building an unchanged tar distribution) -- it just
outputs a non-fatal error if they aren't found. I've tweaked the Makefile to
output a less alarming warning while still mentioning when the man pages did
not get created.

For the case of a later install of yodl, configure would need to be rerun to
change the Makefile's "all" target to depend on "man" instead of "man-copy" (or
the user could run "make man" explicitly).

--
You are receiving this mail because:
You are the QA Contact for the bug.

--
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html