[Bug 11594] New: unnecessary build time dependency (mkproto.pl, perl)

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[Bug 11594] New: unnecessary build time dependency (mkproto.pl, perl)

samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=11594

            Bug ID: 11594
           Summary: unnecessary build time dependency (mkproto.pl, perl)
           Product: rsync
           Version: 3.1.2
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5
         Component: core
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]

When building rsync from its distfile,

   perl ./mkproto.pl ./*.c ./lib/compat.c

will always run, even though up-to-date versions of proto.h and
proto.h-tstamp are provided by the distfile.

The reason is the following target:

   proto.h-tstamp: $(srcdir)/*.c $(srcdir)/lib/compat.c config.h
           perl $(srcdir)/mkproto.pl $(srcdir)/*.c $(srcdir)/lib/compat.c

which declares config.h (created by the configure script, obviously
always newer than the proto.h file provided by the distfile) as its
source without actually using the file.

Removing config.h from the list of proto.h-tstamp sources eliminates
the need for perl when building rsync from its distfile.

--
You are receiving this mail because:
You are the QA Contact for the bug.

--
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html